jnd/beszel-ipv6
1
0
Fork 0
mirror of https://github.com/henrygd/beszel.git synced 2026-10-01 05:47:48 +02:00
Code Issues Packages Projects Releases 2 Wiki Activity

fix(agent): handle partial NVMe SMART data (#2340)

Browse Source
This commit is contained in:
spatiumstas
2026-09-29 19:09:32 +03:00
committed by GitHub
parent 1997984325
commit 67c5905b36
3 changed files with 51 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
agent/smart_test.go
View File

@@ -837,6 +837,27 @@ func TestParseSmartOutputMarksVerified(t *testing.T) {
assert.True(t, device.typeVerified)
}
func TestParseSmartForNvmeRejectsIdentityOnlyResponse(t *testing.T) {
jsonPayload := []byte(`{
"smartctl": {"exit_status": 2},
"device": {"name": "/dev/nvme0", "type": "nvme"},
"model_name": "Netac NVMe SSD 500GB",
"serial_number": "IDENTITY-ONLY",
"user_capacity": {"bytes": 500107862016}
}`)
sm := &SmartManager{SmartDataMap: make(map[string]*smart.SmartData)}
hasData, exitStatus := sm.parseSmartForNvme(jsonPayload, "")
assert.False(t, hasData)
assert.Equal(t, 2, exitStatus)
assert.NotContains(t, sm.SmartDataMap, "IDENTITY-ONLY")
device := &DeviceInfo{Name: "/dev/nvme0", Type: "nvme"}
assert.False(t, sm.parseSmartOutput(device, jsonPayload))
assert.NotContains(t, sm.SmartDataMap, "IDENTITY-ONLY")
}
func TestParseSmartOutputKeepsCustomType(t *testing.T) {
fixturePath := filepath.Join("test-data", "smart", "sda.json")
data, err := os.ReadFile(fixturePath)