jnd/beszel-ipv6
1
0
Fork 0
mirror of https://github.com/henrygd/beszel.git synced 2026-04-08 22:11:50 +02:00
Code Issues Packages Projects Releases 2 Wiki Activity

fix(agent): add safety check for read returning negative bytes (#1799)

Browse Source
This commit is contained in:
henrygd
2026-04-07 18:41:22 -04:00
parent c3dffff5e4
commit ea80f3c5a2
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
agent/gpu_amd_linux.go
View File

@@ -156,6 +156,7 @@ func (gm *GPUManager) updateAmdGpuData(cardPath string) bool {
func readSysfsFloat(path string) (float64, error) { func readSysfsFloat(path string) (float64, error) {
val, err := utils.ReadStringFileLimited(path, 64) val, err := utils.ReadStringFileLimited(path, 64)
if err != nil { if err != nil {
slog.Debug("Failed to read sysfs value", "path", path, "error", err)
return 0, err return 0, err
} }
return strconv.ParseFloat(val, 64) return strconv.ParseFloat(val, 64)

4
agent/utils/utils.go
View File

@@ -1,6 +1,7 @@
package utils package utils
import ( import (
"fmt"
"io" "io"
"math" "math"
"os" "os"
@@ -68,6 +69,9 @@ func ReadStringFileLimited(path string, maxSize int) (string, error) {
if err != nil && err != io.EOF { if err != nil && err != io.EOF {
return "", err return "", err
} }
if n < 0 {
return "", fmt.Errorf("%s returned negative bytes: %d", path, n)
}
return strings.TrimSpace(string(buf[:n])), nil return strings.TrimSpace(string(buf[:n])), nil
} }