mirror of
https://github.com/henrygd/beszel.git
synced 2026-09-21 00:47:47 +02:00
aa1d67a122
Battery names come from firmware (sysfs model_name on Linux), which does not guarantee valid UTF-8. The hub decodes agent payloads using the default fxamacker/cbor decode mode, which rejects invalid UTF-8, so a single bad byte in a battery name makes the hub drop the entire payload and mark the system down until the agent is downgraded.
49 lines
1.9 KiB
Go
49 lines
1.9 KiB
Go
package battery
|
|
|
|
import (
|
|
"testing"
|
|
"unicode/utf8"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPrimarySelection(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
bats []Battery
|
|
want string
|
|
}{
|
|
{"largest reported capacity", []Battery{{Name: "Small", FullChargeCapacity: 20, HasFullChargeCapacity: true, System: true}, {Name: "Large", FullChargeCapacity: 80, HasFullChargeCapacity: true}}, "Large"},
|
|
{"reported ranks over missing", []Battery{{Name: "Unknown", System: true}, {Name: "Known", FullChargeCapacity: 1, HasFullChargeCapacity: true}}, "Known"},
|
|
{"system wins capacity tie", []Battery{{Name: "Peripheral", FullChargeCapacity: 50, HasFullChargeCapacity: true}, {Name: "System", FullChargeCapacity: 50, HasFullChargeCapacity: true, System: true}}, "System"},
|
|
{"name resolves final tie", []Battery{{Name: "Zed"}, {Name: "Alpha"}}, "Alpha"},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, ok := Primary(tt.bats)
|
|
require.True(t, ok)
|
|
assert.Equal(t, tt.want, got.Name)
|
|
})
|
|
}
|
|
_, ok := Primary(nil)
|
|
assert.False(t, ok)
|
|
}
|
|
|
|
func TestNormalizeBatteriesFallbackNames(t *testing.T) {
|
|
bats := normalizeBatteries([]Battery{{}, {}, {Name: "Mouse"}, {Name: "Mouse"}})
|
|
assert.Equal(t, []string{"Battery 1", "Battery 2", "Mouse", "Mouse (2)"}, []string{bats[0].Name, bats[1].Name, bats[2].Name, bats[3].Name})
|
|
}
|
|
|
|
func TestNormalizeBatteriesStripsInvalidUTF8(t *testing.T) {
|
|
// Firmware occasionally reports names that are not valid UTF-8 (a ThinkPad
|
|
// reporting "LNV-5B11K63024@\xd0" in model_name is a real example).
|
|
bats := normalizeBatteries([]Battery{{Name: "LNV-5B11K63024@\xd0"}, {Name: "\xff\xfe"}})
|
|
assert.Equal(t, "LNV-5B11K63024@", bats[0].Name)
|
|
// A name made up entirely of invalid bytes falls back to the generic name.
|
|
assert.Equal(t, "Battery 2", bats[1].Name)
|
|
for _, b := range bats {
|
|
assert.True(t, utf8.ValidString(b.Name))
|
|
}
|
|
}
|